Fix OOM crash during dashcam upload: stream multipart body instead of buffering in memory

First real-hardware test of dashcam retrieval kept crashing the whole
yaris-obd service (repeated SIGKILL/OOM on the Pi 3's ~900MB RAM) a few
minutes into every run, aborting in-flight file copies. Root cause:
_upload_dashcam_files() used requests.post(files={"file": f}), which
builds the entire multipart/form-data body in memory before sending -
fine for small payloads, but this dashcam's real clips average ~320MB
each (up to a couple hundred more with overhead), so every dashcam
upload attempt alone could push the process well past 300-600MB, and
the Pi's OOM killer stepped in immediately.

Reproduced in isolation: uploading a 300MB file the old way spiked the
client process from 28MB to 628MB RSS; switching to requests-toolbelt's
MultipartEncoder (which streams the file in chunks as the request body
is sent, instead of materializing it up front) kept it flat at ~29MB
for the same upload, with an identical byte-for-byte result on the
receiving end. No server-side changes needed - the wire format is
unchanged, still ordinary multipart/form-data.

Added requests-toolbelt to requirements.txt.

Co-authored-by: Copilot <[email protected]>

This commit is contained in:

Mathieu Moran

2026-08-08 21:56:22 -04:00

co-authored by

Copilot

parent 833f008671

commit f88b57d368

2 changed files with 20 additions and 4 deletions

requirements.txt

+2 -1

View File

@@ -5,4 +5,5 @@ pymongo
 python-dotenv
 pyserial
 obd
 requests
 requests
 requests-toolbelt