quoije/yaris-obd
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix trip delete button: layout and click handler

Browse Source 
- text-nowrap on action cell so Replay+trash stay on same line
- Delete button inline with Replay (no whitespace between)
- Explicit deletable guard in click handler

Co-authored-by: Copilot <[email protected]>
This commit is contained in:
Mathieu Moran
2026-08-10 04:45:05 -04:00
co-authored by Copilot
parent 7aa9ffda16
commit 72e4c1b1d7
1 changed files with 22 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files
static/js/history.js
+8 -6
View File
@@ -203,24 +203,25 @@
<td>${formatDuration(trip.duration_seconds)}</td> <td>${formatDuration(trip.duration_seconds)}</td>
<td>${formatSpeed(trip.max_speed_kmh)}</td> <td>${formatSpeed(trip.max_speed_kmh)}</td>
<td class="text-muted small">${trip.odo_start_km != null ? trip.odo_start_km.toFixed(0) + ' → ' + trip.odo_end_km.toFixed(0) + ' km' : '—'}</td> <td class="text-muted small">${trip.odo_start_km != null ? trip.odo_start_km.toFixed(0) + ' → ' + trip.odo_end_km.toFixed(0) + ' km' : '—'}</td>
<td class="text-end d-none d-sm-table-cell"> <td class="text-end text-nowrap d-none d-sm-table-cell">
<button class="btn btn-sm btn-primary" type="button" data-trip-id="${trip.id}"> <button class="btn btn-sm btn-primary" type="button" data-trip-id="${trip.id}">
Replay Replay
</button> </button>${deleteBtn}
${deleteBtn}
</td>`; </td>`;
body.appendChild(row); body.appendChild(row);
}); });
} }
body.addEventListener("click", function (event) { body.addEventListener("click", function (event) {
// Delete button // Delete button — must check before replay to prevent row click triggering replay
if (deletable) {
const deleteBtn = event.target.closest("[data-delete-trip-id]"); const deleteBtn = event.target.closest("[data-delete-trip-id]");
if (deleteBtn) { if (deleteBtn) {
event.stopPropagation(); event.stopPropagation();
event.preventDefault();
const tripId = deleteBtn.dataset.deleteTripId; const tripId = deleteBtn.dataset.deleteTripId;
const date = deleteBtn.closest("tr").querySelector("td").textContent; const date = deleteBtn.closest("tr").querySelector("td").textContent.trim();
window.confirmDelete(`Delete trip from ${date}? The raw GPS data is kept — only the computed trip record is removed.`) window.confirmDelete(`Delete trip from ${date}?\n\nThe raw GPS data is kept — only this computed trip record is removed.`)
.then(function(confirmed) { .then(function(confirmed) {
if (!confirmed) return; if (!confirmed) return;
return fetch(`/api/v1/portal/trip/${tripId}`, { method: "DELETE" }) return fetch(`/api/v1/portal/trip/${tripId}`, { method: "DELETE" })
@@ -232,6 +233,7 @@
}); });
return; return;
} }
}
// Replay button click (desktop) or row click (mobile) // Replay button click (desktop) or row click (mobile)
const button = event.target.closest("[data-trip-id]"); const button = event.target.closest("[data-trip-id]");