Add loading and error states for movie lists

Co-authored-by: mathieumoran1 <[email protected]>

public/js/app_checklist.js

@@ -1,5 +1,35 @@
 window.onload = async function () {
     const token = localStorage.getItem('auth_token');
+    const movieTableBody = document.getElementById('movie-table-body');
+
+    function showTableLoading() {
+      if (!movieTableBody) return;
+      movieTableBody.innerHTML = `
+        <tr>
+          <td colspan="3" class="text-center py-4" aria-live="polite" aria-busy="true">
+            <div class="d-inline-flex align-items-center gap-2">
+              <div class="spinner-border text-secondary" role="status" aria-label="Chargement">
+                <span class="visually-hidden">Chargement...</span>
+              </div>
+              <span>Chargement…</span>
+            </div>
+          </td>
+        </tr>
+      `;
+    }
+
+    function showTableError(message) {
+      if (!movieTableBody) return;
+      movieTableBody.innerHTML = `
+        <tr>
+          <td colspan="3">
+            <div class="alert alert-danger my-2" role="alert">
+              ${message || 'Erreur lors du chargement.'}
+            </div>
+          </td>
+        </tr>
+      `;
+    }
 
     const DEFAULT_COMPLETION_MODAL = Object.freeze({
       title: 'Félicitations! very nice 🎉🎉🎉',
@@ -155,6 +185,13 @@ window.onload = async function () {
       window.location.href = '/';
     }
 
+    showTableLoading();
+
+    let movies = [];
+    let watchedMovies = [];
+    let watchedMoviesInYear = [];
+    let movieImdbIds = new Set();
+    try {
       // Fetch remaining data in parallel (Render latency is high).
       const [completionModalContent, moviesRes, watchedRes] = await Promise.all([
         fetchCompletionModalContent(),
@@ -176,18 +213,21 @@ window.onload = async function () {
         return;
       }
 
-    const movies = await moviesRes.json();
+      movies = await moviesRes.json();
 
       // Sort movies alphabetically by title
       movies.sort((a, b) => a.title.localeCompare(b.title, 'fr', { sensitivity: 'base' }));
 
-    let watchedMovies = [];
       if (watchedRes.ok) {
         watchedMovies = await watchedRes.json();
       }
+    } catch (e) {
+      showTableError('Impossible de charger la checklist. Réessaie dans quelques instants.');
+      return;
+    }
 
-    const movieImdbIds = new Set(movies.map((m) => m.imdb_id).filter(Boolean));
+    movieImdbIds = new Set(movies.map((m) => m.imdb_id).filter(Boolean));
-    let watchedMoviesInYear = watchedMovies.filter((wm) => movieImdbIds.has(wm.imdb_id));
+    watchedMoviesInYear = watchedMovies.filter((wm) => movieImdbIds.has(wm.imdb_id));
 
     const totalMoviesCount = movies.length;
     const watchedMoviesCount = watchedMoviesInYear.length;
@@ -248,7 +288,7 @@ window.onload = async function () {
 
     updateProgressBar(watchedMoviesCount, totalMoviesCount);
 
-    const movieTableBody = document.getElementById('movie-table-body');
+    if (movieTableBody) movieTableBody.innerHTML = '';
     movies.forEach(movie => {
       const watchedMovie = watchedMoviesInYear.find(wm => wm.imdb_id === movie.imdb_id);
       const watchedDate = watchedMovie ? new Date(watchedMovie.watchedDate).toLocaleString() : '';

public/js/app_movies.js

@@ -1,4 +1,24 @@
 window.onload = async function () {
+    function setLoading(el) {
+      if (!el) return;
+      el.innerHTML = `
+        <div class="d-flex justify-content-center align-items-center my-5" aria-live="polite" aria-busy="true">
+          <div class="spinner-border text-secondary" role="status" aria-label="Chargement">
+            <span class="visually-hidden">Chargement...</span>
+          </div>
+        </div>
+      `;
+    }
+
+    function setLoadError(el, message) {
+      if (!el) return;
+      el.innerHTML = `
+        <div class="alert alert-danger my-3" role="alert">
+          ${message || 'Erreur lors du chargement.'}
+        </div>
+      `;
+    }
+
     async function fetchActiveYear() {
       try {
         const res = await fetch('/api/settings/year', { method: 'GET' });
@@ -105,9 +125,13 @@ window.onload = async function () {
       window.location.href = '/';
     }
 
+    const moviesList = document.getElementById('movies-list');
+    setLoading(moviesList);
+
     // Populate "Dernière mise à jour des films" banner (per active year)
     await fetchMoviesLastUpdated(activeYear, token);
 
+    try {
       // Fetch movies + watched list in parallel (Render latency is high).
       const [res, watchedRes] = await Promise.all([
         fetch(`/api/movies?year=${encodeURIComponent(String(activeYear))}`, {
@@ -136,7 +160,6 @@ window.onload = async function () {
         watchedMovies = await watchedRes.json();
       }
 
-    const moviesList = document.getElementById('movies-list');
       const movieImdbIds = new Set(movies.map((m) => m.imdb_id).filter(Boolean));
       const watchedMoviesInYear = watchedMovies.filter((wm) => movieImdbIds.has(wm.imdb_id));
 
@@ -146,6 +169,8 @@ window.onload = async function () {
       const ratioText = `Vu: ${watchedMoviesCount} / ${totalMoviesCount} (${ratioPct}%)`;
       document.getElementById('watched-ratio').innerText = ratioText;
 
+      if (moviesList) moviesList.innerHTML = '';
+
       movies.forEach(movie => {
         const isChecked = watchedMoviesInYear.some(watchedMovie => watchedMovie.imdb_id === movie.imdb_id);
         const watchedMovie = watchedMoviesInYear.find(wm => wm.imdb_id === movie.imdb_id);
@@ -181,6 +206,9 @@ window.onload = async function () {
           </div>`;
         moviesList.appendChild(movieDiv);
       });
+    } catch (e) {
+      setLoadError(moviesList, 'Impossible de charger la liste des films. Réessaie dans quelques instants.');
+    }
 
     document.getElementById('log-off').addEventListener('click', function () {
       localStorage.removeItem('auth_token');